SystemSh0cker/gocsaf
1
0
Fork 0
mirror of https://github.com/gocsaf/csaf.git synced 2025-12-22 18:15:42 +01:00
Code Issues Releases Activity Actions

Avoid memory leak

Browse source 
Move `resp.Body.Close()` before check of status code.

Reported by @mgoetzegb here: https://github.com/gocsaf/csaf/pull/625#issuecomment-2744067770
This commit is contained in:
koplas 2025-03-24 13:32:43 +01:00
parent 0848143a0b
commit 2c5ef1fd5f
No known key found for this signature in database
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
cmd/csaf_downloader/downloader.go
View file

@ -781,11 +781,11 @@ func loadSignature(client util.Client, p string) (*crypto.PGPSignature, []byte,
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
return nil, nil, fmt.Errorf( return nil, nil, fmt.Errorf(
"fetching signature from '%s' failed: %s (%d)", p, resp.Status, resp.StatusCode) "fetching signature from '%s' failed: %s (%d)", p, resp.Status, resp.StatusCode)
} }
defer resp.Body.Close()
data, err := io.ReadAll(resp.Body) data, err := io.ReadAll(resp.Body)
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
@ -846,11 +846,11 @@ func loadHash(client util.Client, p string) ([]byte, []byte, error) {
if err != nil { if err != nil {
return nil, nil, err return nil, nil, err
} }
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK { if resp.StatusCode != http.StatusOK {
return nil, nil, fmt.Errorf( return nil, nil, fmt.Errorf(
"fetching hash from '%s' failed: %s (%d)", p, resp.Status, resp.StatusCode) "fetching hash from '%s' failed: %s (%d)", p, resp.Status, resp.StatusCode)
} }
defer resp.Body.Close()
var data bytes.Buffer var data bytes.Buffer
tee := io.TeeReader(resp.Body, &data) tee := io.TeeReader(resp.Body, &data)
hash, err := util.HashFromReader(tee) hash, err := util.HashFromReader(tee)