From 2e129b9dc84087c1e5f24218f93c2772c1d8144b Mon Sep 17 00:00:00 2001 From: JanHoefelmeyer Date: Fri, 8 Sep 2023 11:00:50 +0200 Subject: [PATCH] Clean up certs_test.go a bit --- internal/certs/certs_test.go | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/internal/certs/certs_test.go b/internal/certs/certs_test.go index 3e49e34..ed5d639 100644 --- a/internal/certs/certs_test.go +++ b/internal/certs/certs_test.go @@ -3,26 +3,24 @@ package certs import "testing" func TestLoadCertificates(t *testing.T) { - goodTestCert := "data/testclient.crt" - goodTestkey := "data/testclientkey.pem" - goodPassphrase := "security123" -// missingTestCert := "data/testclient_missing.crt" + TestCert := "data/testclient.crt" + Testkey := "data/testclientkey.pem" + Passphrase := "security123" missingTestkey := "data/testclientkey_missing.pem" -// missingPassphrase := "" - if certificate, err := LoadCertificate(&goodTestCert, &goodTestkey, nil); certificate == nil || err != nil { + if certificate, err := LoadCertificate(&TestCert, &Testkey, nil); certificate == nil || err != nil { t.Errorf("Failure: Couldn't load supposedly valid certificate.") } - if certificate, err := LoadCertificate(nil, &goodTestkey, nil); certificate != nil || err == nil { + if certificate, err := LoadCertificate(nil, &Testkey, nil); certificate != nil || err == nil { t.Errorf("Failure: No error despite missing certificate") } - if certificate, err := LoadCertificate(&goodTestCert, &missingTestkey, nil); certificate != nil || err == nil { + if certificate, err := LoadCertificate(&TestCert, &missingTestkey, nil); certificate != nil || err == nil { t.Errorf("Failure: No Failure while loading certificate using missing key.") } - if certificate, err := LoadCertificate(&goodTestCert, &goodTestkey, &goodPassphrase); certificate == nil || err != nil { + if certificate, err := LoadCertificate(&TestCert, &Testkey, &Passphrase); certificate == nil || err != nil { t.Errorf("Failure: Couldn't load supposedly valid certificate with passphrase.") } - if certificate, err := LoadCertificate(&goodTestCert, &missingTestkey, &goodPassphrase); certificate != nil || err == nil { + if certificate, err := LoadCertificate(&TestCert, &missingTestkey, &Passphrase); certificate != nil || err == nil { t.Errorf("Failure: No Failure while loading certificate using missing key with passphrase.") } }