Started with checking the CSAF files.

cmd/csaf_checker/checks.go

@@ -105,9 +105,9 @@ func (p *processor) jsonPath(expr string) (interface{}, error) {
 	return eval(context.Background(), p.pmd)
 }
 
-func (p *processor) checkTLS(url string) {
+func (p *processor) checkTLS(u string) {
-	if !strings.HasPrefix(strings.ToLower(url), "https://") {
+	if x, err := url.Parse(u); err == nil && x.Scheme != "https" {
-		p.noneTLS[url] = struct{}{}
+		p.noneTLS[u] = struct{}{}
 	}
 }
 
@@ -146,6 +146,60 @@ func (p *processor) httpClient() *http.Client {
 	return &client
 }
 
+func (p *processor) integrity(
+	files []string,
+	base string,
+	lg func(string, ...interface{}),
+) error {
+	b, err := url.Parse(base)
+	if err != nil {
+		return err
+	}
+	client := p.httpClient()
+	for _, f := range files {
+		fp, err := url.Parse(f)
+		if err != nil {
+			return err
+		}
+		u := b.ResolveReference(fp).String()
+		p.checkTLS(u)
+		res, err := client.Get(u)
+		if err != nil {
+			lg("Fetching %s failed: %v.", u, err)
+			continue
+		}
+		if res.StatusCode != http.StatusOK {
+			lg("Fetchinf %s failed: Status code %d (%s)",
+				u, res.StatusCode, res.Status)
+			continue
+		}
+		data, err := func() ([]byte, error) {
+			defer res.Body.Close()
+			return io.ReadAll(res.Body)
+		}()
+		if err != nil {
+			lg("Reading %s failed: %v", u, err)
+			continue
+		}
+		var doc interface{}
+		if err := json.Unmarshal(data, &doc); err != nil {
+			lg("Failed to unmarshal %s: %v", u, err)
+			continue
+		}
+		errors, err := csaf.ValidateCSAF(doc)
+		if err != nil {
+			lg("Failed to validate %s: %v", u, err)
+			continue
+		}
+		if len(errors) > 0 {
+			lg("CSAF file %s has %d validation errors.", u, len(errors))
+		}
+		// TODO: Implement check sums
+		// TODO: Implement signature check.
+	}
+	return nil
+}
+
 type baseCheck struct {
 	exec        int
 	num         int
@@ -372,18 +426,19 @@ func (sc *securityCheck) run(p *processor, domain string) error {
 		return err
 	}
 	if res, err = client.Do(req); err != nil {
-		sc.sprintf("Cannot fetch %s from security.txt: %s", u, err.Error())
+		sc.sprintf("Cannot fetch %s from security.txt: %v", u, err)
 		return nil
 	}
 	if res.StatusCode != http.StatusOK {
-		sc.sprintf("Fetching %s failed. Status code %d (%s).", u, res.StatusCode, res.Status)
+		sc.sprintf("Fetching %s failed. Status code %d (%s).",
+			u, res.StatusCode, res.Status)
 		return nil
 	}
 	defer res.Body.Close()
 	// Compare checksums to already read provider-metadata.json.
 	h := sha256.New()
 	if _, err := io.Copy(h, res.Body); err != nil {
-		sc.sprintf("Reading %s failed: %s.", u, err.Error())
+		sc.sprintf("Reading %s failed: %v.", u, err)
 		return nil
 	}
 
@@ -407,13 +462,114 @@ func (dpc *dnsPathCheck) run(*processor, string) error {
 	return nil
 }
 
-func (ofpyc *oneFolderPerYearCheck) report(p *processor, domain *Domain) {
+func basePath(p string) (string, error) {
-	ofpyc.baseCheck.report(p, domain)
+	u, err := url.Parse(p)
-	// TODO: Implement me!
+	if err != nil {
+		return "", err
+	}
+	ep := u.EscapedPath()
+	if idx := strings.LastIndexByte(ep, '/'); idx != -1 {
+		ep = ep[:idx]
+	}
+	user := u.User.String()
+	if user != "" {
+		user += "@"
+	}
+	return u.Scheme + "://" + user + u.Host + "/" + ep, nil
 }
 
-func (ofpyc *oneFolderPerYearCheck) run(*processor, string) error {
+func (ofpyc *oneFolderPerYearCheck) processFeed(
-	// TODO: Implement me!
+	p *processor,
+	feed string,
+) error {
+	client := p.httpClient()
+	res, err := client.Get(feed)
+	if err != nil {
+		ofpyc.sprintf("Cannot fetch feed %s: %v.", feed, err)
+		return nil
+	}
+	if res.StatusCode != http.StatusOK {
+		ofpyc.sprintf("Fetching %s failed. Status code %d (%s)",
+			feed, res.StatusCode, res.Status)
+		return nil
+	}
+	rfeed, err := func() (*csaf.ROLIEFeed, error) {
+		defer res.Body.Close()
+		return csaf.LoadROLIEFeed(res.Body)
+	}()
+	if err != nil {
+		ofpyc.sprintf("Loading ROLIE feed failed: %v.", err)
+		return nil
+	}
+	base, err := basePath(feed)
+	if err != nil {
+		return err
+	}
+
+	// Extract the CSAF files from feed.
+	var files []string
+	for _, f := range rfeed.Entry {
+		for i := range f.Link {
+			files = append(files, f.Link[i].HRef)
+		}
+	}
+	return p.integrity(files, base, ofpyc.sprintf)
+}
+
+func (ofpyc *oneFolderPerYearCheck) processFeeds(
+	p *processor,
+	domain string,
+	feeds [][]csaf.Feed,
+) error {
+	base, err := url.Parse("https://" + domain + "/.well-known/csaf/")
+	if err != nil {
+		return err
+	}
+	for i := range feeds {
+		for j := range feeds[i] {
+			feed := &feeds[i][j]
+			if feed.URL == nil {
+				continue
+			}
+			up, err := url.Parse(string(*feed.URL))
+			if err != nil {
+				ofpyc.sprintf("Invalid URL %s in feed: %v.", *feed.URL, err)
+				continue
+			}
+			feedURL := base.ResolveReference(up).String()
+			p.checkTLS(feedURL)
+			if err := ofpyc.processFeed(p, feedURL); err != nil {
+				return err
+			}
+		}
+	}
+	return nil
+}
+
+func (ofpyc *oneFolderPerYearCheck) run(p *processor, domain string) error {
+	// Check for ROLIE
+	rolie, err := p.jsonPath("$.distributions[*].rolie.feeds")
+	if err != nil {
+		return err
+	}
+
+	fs, hasRolie := rolie.([]interface{})
+	hasRolie = hasRolie && len(fs) > 0
+
+	if hasRolie {
+		var feeds [][]csaf.Feed
+		if err := util.ReMarshalJSON(&feeds, rolie); err != nil {
+			ofpyc.sprintf("ROLIE feeds are not compatible: %v.", err)
+			return nil
+		}
+		if err := ofpyc.processFeeds(p, domain, feeds); err != nil {
+			return err
+		}
+	} else {
+		// No rolie feeds
+		// TODO: Implement me!
+	}
+
 	return nil
 }
 

cmd/csaf_checker/main.go

@@ -106,13 +106,13 @@ func buildChecks() []check {
 		&securityCheck{baseCheck{exec: 2, num: 8, description: "security.txt"}},
 		&wellknownMetadataCheck{baseCheck{exec: 3, num: 9, description: "/.well-known/csaf/provider-metadata.json"}},
 		&dnsPathCheck{baseCheck{exec: 4, num: 10, description: "DNS path"}},
-		&oneFolderPerYearCheck{baseCheck{exec: 5, num: 11, description: "One folder per year"}},
+		&oneFolderPerYearCheck{baseCheck{exec: 6, num: 11, description: "One folder per year"}},
-		&indexCheck{baseCheck{exec: 6, num: 12, description: "index.txt"}},
+		&indexCheck{baseCheck{exec: 7, num: 12, description: "index.txt"}},
-		&changesCheck{baseCheck{exec: 7, num: 13, description: "changes.csv"}},
+		&changesCheck{baseCheck{exec: 8, num: 13, description: "changes.csv"}},
-		&directoryListingsCheck{baseCheck{exec: 8, num: 14, description: "Directory listings"}},
+		&directoryListingsCheck{baseCheck{exec: 9, num: 14, description: "Directory listings"}},
-		&integrityCheck{baseCheck{exec: 9, num: 18, description: "Integrity"}},
+		&integrityCheck{baseCheck{exec: 11, num: 18, description: "Integrity"}},
-		&signaturesCheck{baseCheck{exec: 11, num: 19, description: "Signatures"}},
+		&signaturesCheck{baseCheck{exec: 12, num: 19, description: "Signatures"}},
-		&publicPGPKeyCheck{baseCheck{exec: 10, num: 20, description: "Public PGP Key"}},
+		&publicPGPKeyCheck{baseCheck{exec: 5, num: 20, description: "Public PGP Key"}},
 	}
 }
 

util/json.go

@@ -8,7 +8,9 @@
 
 package util
 
-import "encoding/json"
+import (
+	"encoding/json"
+)
 
 // ReMarshalJSON transforms data from src to dst via JSON marshalling.
 func ReMarshalJSON(dst, src interface{}) error {