SystemSh0cker/gocsaf
1
0
Fork 0
mirror of https://github.com/gocsaf/csaf.git synced 2025-12-22 11:55:40 +01:00
Code Issues Releases Activity Actions

Merge pull request #78 from csaf-poc/dev-fix-typos2

Browse source 
Improve checker's reporting texts
This commit is contained in:
Sascha L. Teichmann 2022-03-03 12:23:20 +01:00 • committed by GitHub
commit b852ae4ec1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

26
cmd/csaf_checker/reporters.go
View file

@ -3,8 +3,8 @@
// //
// SPDX-License-Identifier: MIT // SPDX-License-Identifier: MIT
// //
// SPDX-FileCopyrightText: 2021 German Federal Office for Information Security (BSI) <https://www.bsi.bund.de> // SPDX-FileCopyrightText: 2022 German Federal Office for Information Security (BSI) <https://www.bsi.bund.de>
// Software-Engineering: 2021 Intevation GmbH <https://intevation.de> // Software-Engineering: 2022 Intevation GmbH <https://intevation.de>
package main package main
@ -49,7 +49,7 @@ func (r *tlsReporter) report(p *processor, domain *Domain) {
return return
} }
if len(p.noneTLS) == 0 { if len(p.noneTLS) == 0 {
req.message("All tested URLs were https.") req.message("All tested URLs were HTTPS.")
return return
} }
@ -60,7 +60,7 @@ func (r *tlsReporter) report(p *processor, domain *Domain) {
i++ i++
} }
sort.Strings(urls) sort.Strings(urls)
req.message("Following none https URLs were used:") req.message("Following non-HTTPS URLs were used:")
req.message(urls...) req.message(urls...)
} }
@ -91,7 +91,7 @@ func (r *providerMetadataReport) report(p *processor, domain *Domain) {
return return
} }
if len(p.badProviderMetadatas) == 0 { if len(p.badProviderMetadatas) == 0 {
req.message("No problems with provider metadata.") req.message("Found good provider metadata.")
return return
} }
req.Messages = p.badProviderMetadatas req.Messages = p.badProviderMetadatas
@ -104,7 +104,7 @@ func (r *securityReporter) report(p *processor, domain *Domain) {
return return
} }
if len(p.badSecurities) == 0 { if len(p.badSecurities) == 0 {
req.message("No problems with security.txt found.") req.message("Found good security.txt.")
return return
} }
req.Messages = p.badSecurities req.Messages = p.badSecurities
@ -113,19 +113,19 @@ func (r *securityReporter) report(p *processor, domain *Domain) {
func (r *wellknownMetadataReporter) report(_ *processor, domain *Domain) { func (r *wellknownMetadataReporter) report(_ *processor, domain *Domain) {
// TODO: Implement me! // TODO: Implement me!
req := r.requirement(domain) req := r.requirement(domain)
_ = req req.message("(Not checked, missing implementation.)")
} }
func (r *dnsPathReporter) report(_ *processor, domain *Domain) { func (r *dnsPathReporter) report(_ *processor, domain *Domain) {
// TODO: Implement me! // TODO: Implement me!
req := r.requirement(domain) req := r.requirement(domain)
_ = req req.message("(Not checked, missing implementation.)")
} }
func (r *oneFolderPerYearReport) report(p *processor, domain *Domain) { func (r *oneFolderPerYearReport) report(p *processor, domain *Domain) {
req := r.requirement(domain) req := r.requirement(domain)
if !used(p.badFolders) { if !used(p.badFolders) {
req.message("No checks if file are in right folders were performed.") req.message("No checks if files are in right folders were performed.")
return return
} }
if len(p.badFolders) == 0 { if len(p.badFolders) == 0 {
@ -142,7 +142,7 @@ func (r *indexReporter) report(p *processor, domain *Domain) {
return return
} }
if len(p.badIndices) == 0 { if len(p.badIndices) == 0 {
req.message("No problems with index.txt found.") req.message("Found good index.txt.")
return return
} }
req.Messages = p.badIndices req.Messages = p.badIndices
@ -155,7 +155,7 @@ func (r *changesReporter) report(p *processor, domain *Domain) {
return return
} }
if len(p.badChanges) == 0 { if len(p.badChanges) == 0 {
req.message("No problems with changes.csv found.") req.message("Found good changes.csv.")
return return
} }
req.Messages = p.badChanges req.Messages = p.badChanges
@ -195,11 +195,11 @@ func (r *signaturesReporter) report(p *processor, domain *Domain) {
func (r *publicPGPKeyReporter) report(p *processor, domain *Domain) { func (r *publicPGPKeyReporter) report(p *processor, domain *Domain) {
req := r.requirement(domain) req := r.requirement(domain)
if !used(p.badPGPs) { if !used(p.badPGPs) {
req.message("No PGP keys loaded.") req.message("No public OpenPGP keys loaded.")
return return
} }
req.Messages = p.badPGPs req.Messages = p.badPGPs
if len(p.keys) > 0 { if len(p.keys) > 0 {
req.message(fmt.Sprintf("%d PGP key(s) loaded successfully.", len(p.keys))) req.message(fmt.Sprintf("%d public OpenPGP key(s) loaded.", len(p.keys)))
} }
} }