koplas
c63bf3db9f
Add schema violation logging to aggregator
2025-06-13 18:24:54 +02:00
Paul Schwabauer
2f599ab017
Fix aggregator URL handling ( #631 )
...
* Fix aggregator URL handling
Parts of the URL were not path escaped. This results in a wrong URL; if
the provider name contains characters that need to be escaped.
* Simplify JoinPath usage
2025-04-02 17:05:29 +02:00
koplas
2c5ef1fd5f
Avoid memory leak
...
Move `resp.Body.Close()` before check of status code.
Reported by @mgoetzegb here: https://github.com/gocsaf/csaf/pull/625#issuecomment-2744067770
2025-03-24 13:32:43 +01:00
Paul Schwabauer
0848143a0b
Update lint ( #626 )
...
* Update linter
* Format
* Fix lint
2025-03-19 09:39:07 +01:00
Paul Schwabauer
5709b14650
Extend structured logging usage in aggregator ( #622 )
...
* Extend structured logging usage in aggregator
* Use structured logging in advisories processor
* Remove unnecessary inner function
* Format
* Feat: Add verbose flag to example aggregator toml (in comment)
---------
Co-authored-by: JanHoefelmeyer <jan.hoefelmeyer@intevation.de>
2025-03-19 09:04:19 +01:00
Sascha L. Teichmann
5437d8127a
Store downloader in context
2025-03-17 09:10:03 +01:00
Sascha L. Teichmann
a7821265ca
Move advisory downloading to download context method
2025-03-17 08:57:05 +01:00
JanHoefelmeyer
8163f57851
Compare changes dates ( #609 )
...
* Feat: Compare dates in changes.csv to those within the files if existent
* Fix: remove debug output and fix typo
* Make map handling consistent
* Improve: refactor time extraction
* fix: some syntax fixes
* Small nits
* Fix: Check changes before stopping the scan of already tested advisories
* Revert "Fix: Check changes before stopping the scan of already tested advisories - bad way to solve the problem, can cause problems"
This reverts commit d38dc285cc
2025-03-14 10:05:56 +01:00
koplas
534d6f049f
Add content-type error report test
2025-03-10 12:04:46 +01:00
koplas
3cfafa8263
Report error in checker if content type is not correct
...
Related: #606
2025-03-10 11:11:34 +01:00
Paul Schwabauer
3e16741ed5
Merge pull request #554 from gocsaf/sha-handling
...
Improve SHA* marking
2025-03-10 09:40:53 +01:00
Marcus Perlick
ec0c3f9c2c
Fix potential leak of HTTP response body in downloadJSON of csaf_aggregator ( #618 )
2025-03-10 09:24:49 +01:00
koplas
1d1c5698da
Merge branch 'main' into sha-handling
2025-03-05 09:41:29 +01:00
JanHoefelmeyer
82a6929e4d
Fix: Poor phrasing corrected
2025-01-29 09:41:16 +01:00
JanHoefelmeyer
02787b24b7
Update comments, clean up security check
2025-01-29 09:26:59 +01:00
JanHoefelmeyer
7d74543bbb
Fix: Now give errors if lookup methods fail, refactor accordingly
2025-01-29 09:02:18 +01:00
Paul Schwabauer
8e5236a2b6
Merge pull request #602 from gocsaf/remote-validator-warn
...
Warn if no remote validator was specified
2025-01-23 12:40:20 +01:00
koplas
6e8c2ecc05
Check remote validator even if file validation fails
...
This makes it consistent with the handling of schema
validation.
2025-01-23 12:22:11 +01:00
koplas
59d2cef082
Fix typos
2025-01-23 11:53:57 +01:00
koplas
028f468d6f
Fix typo in error message
...
Closes #608
2025-01-23 10:32:13 +01:00
JanHoefelmeyer
b6721e1d5a
Add check for missing either sha256 or sha512 hashes only
2025-01-10 11:42:54 +01:00
koplas
9275a37a9f
Format
2025-01-08 08:50:30 +01:00
koplas
b8a5fa72d5
Fix nil check in downloader
2025-01-08 08:49:42 +01:00
koplas
d8e903587a
Warn only if the other hash could be fetched
2024-12-18 15:37:58 +01:00
Bernhard Reiter
95ff418a27
fix: Content-Type header for JSON responses
...
* Remove `charset=utf-8` parameter, which is not allowed
for JSON, according to rfc8259.
2024-12-18 08:55:48 +01:00
koplas
bc5d149f74
Use exit code 1 for general errors, fix documentation
2024-12-16 19:28:24 +01:00
koplas
d38150c6a0
Add testdata for individual hash forbidden tests
2024-12-16 12:57:28 +01:00
koplas
b1a7620763
Extend processor SHA fetching tests
...
Allow to forbid individual hashes from downloading. This allows to for
testing the behavior, if one of the hashes could not be downloaded.
2024-12-16 12:23:10 +01:00
koplas
9dd4b7fc8d
Add tests for no hash given or available
2024-12-13 15:54:39 +01:00
koplas
a3d6d6acfb
Downgrade error to info in directory hash fetching
2024-12-13 14:26:00 +01:00
koplas
df65ad13cb
Fix: return correct exit code
2024-12-10 10:13:42 +01:00
koplas
68bd04676c
Add requirement checker test data
2024-12-06 13:11:07 +01:00
koplas
5b6af7a4ad
WIP: Add requirement tests
2024-12-04 18:04:08 +01:00
koplas
a51964be3f
Add initial csaf_checker provider test
2024-12-04 16:02:03 +01:00
Sascha L. Teichmann
16e86051c5
Be more precise about exit codes.
2024-12-04 14:27:24 +01:00
koplas
938ceb872a
Return exit code based on validation result
2024-12-04 13:54:38 +01:00
koplas
57953e495f
Warn if no remote validator was specified
2024-12-04 13:23:57 +01:00
ncsc-ie-devs
1daaed2c51
ensure HTTP requests use proxy env vars ( #597 )
...
* fix: ensure HTTP requests use proxy env vars
Updated all instances of `http.Transport` to include the `Proxy` field set to `http.ProxyFromEnvironment`. This ensures that the application respects proxy configuration defined by the `HTTP_PROXY`, `HTTPS_PROXY`, and `NO_PROXY` environment variables.
### Changes:
- Modified `http.Transport` initialization across the codebase to use:
```go
Proxy: http.ProxyFromEnvironment
```
- Ensured TLS configurations remain intact by preserving `TLSClientConfig`.
### Why:
- Previously, HTTP requests bypassed proxy settings due to missing configuration in the transport layer.
- This fix enables compatibility with proxied environments, aligning with standard Go behavior.
### Impact:
- All HTTP and HTTPS traffic now adheres to proxy settings.
- Domains listed in `NO_PROXY` bypass the proxy as expected.
### Verification:
- Tested with proxy environment variables set (`HTTP_PROXY`, `HTTPS_PROXY`).
- Verified requests route through the proxy and `NO_PROXY` works as intended.
* reformat with fmt
---------
Co-authored-by: Cormac Doherty <cormac.doherty@ncsc.gov.ie>
2024-12-02 11:42:54 +01:00
koplas
56509bbb4d
Use new path in tests
2024-11-27 12:51:38 +01:00
koplas
a5f4b10c4e
Merge branch 'main' into sha-handling
2024-11-27 12:39:14 +01:00
koplas
ffb4eff933
Merge unittest into sha-handling
...
commit 990c74a1a686d7ce17824f3b86d7ce13dca6807d279b890079b89009dda6807d24d6ddb5518d18d2c3d18d2c3bf1ddb5518c6d13c94f4fa01819b4896b989e3667ba714735d74ad488e39947a9bf9da1306ca6dfee2520bee797c68e4e5080733ba29f94dedee55aafd9cd9338ae72
2024-11-27 12:15:21 +01:00
koplas
7824f3b48d
Improve hash fetching and logging
2024-11-22 16:56:58 +01:00
koplas
c00dc36547
Remove -h for preferred hash configuration
...
This option was in conflict with the help display.
2024-11-21 12:31:58 +01:00
Bernhard Reiter
e8706e5eb9
feat: perform go path repo move
...
* Change the go module path
from github.com/csaf-poc/csaf_distribution to github.com/gocsaf/csaf.
* Rename archive for release tarballs.
* Adjust testing scripts and documentation.
2024-11-04 13:20:47 +01:00
koplas
c0de0c2b6d
Check if hash present, before sending a request
2024-09-27 15:20:36 +02:00
JanHoefelmeyer
464e88b530
Merge pull request #571 from csaf-poc/fingerprint-no-breaking
...
Improve PGP fingerprint handling
2024-09-09 11:51:09 +02:00
koplas
37c9eaf346
Add CLI flags to specify what hash is preferred
2024-09-09 10:35:41 +02:00
Bernhard Reiter
5231b3386b
docs: improve code comment (minor)
2024-09-07 09:58:14 +02:00
koplas
c2e24f7bbb
Remove check for empty fingerprint
...
The schema validation already catches this error and this check will
never run.
2024-09-06 18:21:25 +02:00
koplas
9037574d96
Improve PGP fingerprint handling
...
Warn if no fingerprint is specified and give more details, if
fingerprint comparison fails.
Closes #555
2024-08-08 12:42:19 +02:00
