SystemSh0cker/monaco-editor
1
0
Fork 0
mirror of https://github.com/microsoft/monaco-editor.git synced 2025-12-22 15:05:39 +01:00
Code Issues Projects Releases Packages Activity

fix: memory leaks from worker recompilation with HMR

Browse source 
Add alreadyCompiled flag to prevent unnecessary worker rebuilds
during development with Hot Module Replacement, which was causing
memory leaks in both webpack and rspack.
This commit is contained in:
Daniil Gaponov 2025-07-10 21:19:07 +02:00
parent f420968fc9
commit 1fcf768d0a
1 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

15
webpack-plugin/src/plugins/AddWorkerEntryPointPlugin.ts
View file

@ -13,11 +13,17 @@ function getCompilerHook(
{ id, entry, filename, chunkFilename, plugins }: IAddWorkerEntryPointPluginOptions { id, entry, filename, chunkFilename, plugins }: IAddWorkerEntryPointPluginOptions
) { ) {
const webpack = compiler.webpack ?? require('webpack'); const webpack = compiler.webpack ?? require('webpack');
let alreadyCompiled = false;
return function ( return function (
compilation: webpack.Compilation, compilation: webpack.Compilation,
callback: (error?: Error | null | false) => void callback: (error?: Error | null | false) => void
) { ) {
if (alreadyCompiled) {
callback();
return;
}
const outputOptions = { const outputOptions = {
filename, filename,
chunkFilename, chunkFilename,
@ -33,7 +39,14 @@ function getCompilerHook(
new SingleEntryPlugin(compiler.context, entry, 'main').apply(childCompiler); new SingleEntryPlugin(compiler.context, entry, 'main').apply(childCompiler);
plugins.forEach((plugin) => plugin.apply(childCompiler)); plugins.forEach((plugin) => plugin.apply(childCompiler));
childCompiler.runAsChild((err?: Error | null) => callback(err)); childCompiler.runAsChild((err?: Error | null) => {
if (err) {
callback(err);
} else {
alreadyCompiled = true;
callback();
}
});
}; };
} }