SystemSh0cker/monaco-editor
1
0
Fork 0
mirror of https://github.com/microsoft/monaco-editor.git synced 2025-12-22 20:52:56 +01:00
Code Issues Projects Releases Packages Activity

website: monaco loading improvements
Some checks failed
CI / CI (push) Has been cancelled

Browse source
This commit is contained in:
Henning Dieterichs 2024-07-16 19:27:14 +02:00 • committed by Henning Dieterichs
parent 5eb2aba338
commit 5181be1011
2 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
website/src/monaco-loader.ts
View file

@ -62,6 +62,10 @@ async function _loadMonaco(setup: IMonacoSetup): Promise<typeof monaco> {
return new Promise((res) => { return new Promise((res) => {
// First load editor.main. If it inlines the plugins, we don't want to try to load them from the server. // First load editor.main. If it inlines the plugins, we don't want to try to load them from the server.
req(["vs/editor/editor.main"], () => { req(["vs/editor/editor.main"], () => {
if ((setup as any).onlyCore) {
res(monaco);
return;
}
req( req(
[ [
"vs/basic-languages/monaco.contribution", "vs/basic-languages/monaco.contribution",

4
website/src/website/components/monaco/MonacoEditor.tsx
View file

@ -17,6 +17,10 @@ export class ControlledMonacoEditor extends React.Component<{
private lastSubscription: monaco.IDisposable | undefined; private lastSubscription: monaco.IDisposable | undefined;
componentDidMount(): void {
this.componentDidUpdate({ value: "" });
}
componentDidUpdate(lastProps: this["props"]) { componentDidUpdate(lastProps: this["props"]) {
const newOnDidValueChange = this.props.onDidValueChange; const newOnDidValueChange = this.props.onDidValueChange;
if (newOnDidValueChange !== lastProps.onDidValueChange) { if (newOnDidValueChange !== lastProps.onDidValueChange) {