SystemSh0cker/monaco-editor
1
0
Fork 0
mirror of https://github.com/microsoft/monaco-editor.git synced 2025-12-22 16:15:41 +01:00
Code Issues Projects Releases Packages Activity

Remove unused IDisposable array

Browse source 
The IDisposables created by the registration of language providers
were originally stored in an array. However, that array is not
actually used anywhere in the code so it should be removed instead.

Signed-off-by: Remy Suen <remy.suen@gmail.com>
This commit is contained in:
Remy Suen 2018-03-03 14:16:24 +09:00
parent e87b2e9445
commit 896f576a64
1 changed files with 12 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/mode.ts
View file

@ -12,7 +12,6 @@ import * as languageFeatures from './languageFeatures';
import Promise = monaco.Promise; import Promise = monaco.Promise;
import Uri = monaco.Uri; import Uri = monaco.Uri;
import IDisposable = monaco.IDisposable;
let javaScriptWorker: (first: Uri, ...more: Uri[]) => Promise<TypeScriptWorker>; let javaScriptWorker: (first: Uri, ...more: Uri[]) => Promise<TypeScriptWorker>;
let typeScriptWorker: (first: Uri, ...more: Uri[]) => Promise<TypeScriptWorker>; let typeScriptWorker: (first: Uri, ...more: Uri[]) => Promise<TypeScriptWorker>;
@ -55,27 +54,23 @@ export function getTypeScriptWorker(): Promise<(first: Uri, ...more: Uri[]) => P
function setupMode(defaults:LanguageServiceDefaultsImpl, modeId:string, language:Language): (first: Uri, ...more: Uri[]) => Promise<TypeScriptWorker> { function setupMode(defaults:LanguageServiceDefaultsImpl, modeId:string, language:Language): (first: Uri, ...more: Uri[]) => Promise<TypeScriptWorker> {
let disposables: IDisposable[] = [];
const client = new WorkerManager(modeId, defaults); const client = new WorkerManager(modeId, defaults);
disposables.push(client);
const worker = (first: Uri, ...more: Uri[]): Promise<TypeScriptWorker> => { const worker = (first: Uri, ...more: Uri[]): Promise<TypeScriptWorker> => {
return client.getLanguageServiceWorker(...[first].concat(more)); return client.getLanguageServiceWorker(...[first].concat(more));
}; };
disposables.push(monaco.languages.registerCompletionItemProvider(modeId, new languageFeatures.SuggestAdapter(worker))); monaco.languages.registerCompletionItemProvider(modeId, new languageFeatures.SuggestAdapter(worker));
disposables.push(monaco.languages.registerSignatureHelpProvider(modeId, new languageFeatures.SignatureHelpAdapter(worker))); monaco.languages.registerSignatureHelpProvider(modeId, new languageFeatures.SignatureHelpAdapter(worker));
disposables.push(monaco.languages.registerHoverProvider(modeId, new languageFeatures.QuickInfoAdapter(worker))); monaco.languages.registerHoverProvider(modeId, new languageFeatures.QuickInfoAdapter(worker));
disposables.push(monaco.languages.registerDocumentHighlightProvider(modeId, new languageFeatures.OccurrencesAdapter(worker))); monaco.languages.registerDocumentHighlightProvider(modeId, new languageFeatures.OccurrencesAdapter(worker));
disposables.push(monaco.languages.registerDefinitionProvider(modeId, new languageFeatures.DefinitionAdapter(worker))); monaco.languages.registerDefinitionProvider(modeId, new languageFeatures.DefinitionAdapter(worker));
disposables.push(monaco.languages.registerReferenceProvider(modeId, new languageFeatures.ReferenceAdapter(worker))); monaco.languages.registerReferenceProvider(modeId, new languageFeatures.ReferenceAdapter(worker));
disposables.push(monaco.languages.registerDocumentSymbolProvider(modeId, new languageFeatures.OutlineAdapter(worker))); monaco.languages.registerDocumentSymbolProvider(modeId, new languageFeatures.OutlineAdapter(worker));
disposables.push(monaco.languages.registerDocumentRangeFormattingEditProvider(modeId, new languageFeatures.FormatAdapter(worker))); monaco.languages.registerDocumentRangeFormattingEditProvider(modeId, new languageFeatures.FormatAdapter(worker));
disposables.push(monaco.languages.registerOnTypeFormattingEditProvider(modeId, new languageFeatures.FormatOnTypeAdapter(worker))); monaco.languages.registerOnTypeFormattingEditProvider(modeId, new languageFeatures.FormatOnTypeAdapter(worker));
disposables.push(new languageFeatures.DiagnostcsAdapter(defaults, modeId, worker)); new languageFeatures.DiagnostcsAdapter(defaults, modeId, worker);
disposables.push(monaco.languages.setLanguageConfiguration(modeId, richEditConfiguration)); monaco.languages.setLanguageConfiguration(modeId, richEditConfiguration);
disposables.push(monaco.languages.setTokensProvider(modeId, createTokenizationSupport(language))); monaco.languages.setTokensProvider(modeId, createTokenizationSupport(language));
return worker; return worker;
} }