Merge pull request #2853 from ValeraS/webpack-plugin

tune(monaco-editor-webpack-plugin): expose plugin options type
This commit is contained in:
Alexandru Dima 2022-01-14 09:52:53 +01:00 committed by GitHub
commit c9e1c9962b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -99,7 +99,8 @@ function resolveDesiredLanguages(
return coalesce(languages.map((id) => languagesById[id])).concat(userCustomLanguages || []);
}
interface IMonacoEditorWebpackPluginOpts {
declare namespace MonacoEditorWebpackPlugin {
interface IMonacoEditorWebpackPluginOpts {
/**
* Include only a subset of the languages supported.
*/
@ -144,8 +145,8 @@ interface IMonacoEditorWebpackPluginOpts {
* log](https://github.com/microsoft/monaco-editor/blob/main/CHANGELOG.md#0220-29012021)).
*/
globalAPI?: boolean;
}
}
interface IInternalMonacoEditorWebpackPluginOpts {
languages: IFeatureDefinition[];
features: IFeatureDefinition[];
@ -158,7 +159,7 @@ interface IInternalMonacoEditorWebpackPluginOpts {
class MonacoEditorWebpackPlugin implements webpack.WebpackPluginInstance {
private readonly options: IInternalMonacoEditorWebpackPluginOpts;
constructor(options: IMonacoEditorWebpackPluginOpts = {}) {
constructor(options: MonacoEditorWebpackPlugin.IMonacoEditorWebpackPluginOpts = {}) {
const monacoEditorPath = options.monacoEditorPath;
const metadata = getEditorMetadata(monacoEditorPath);
const languages = resolveDesiredLanguages(metadata, options.languages, options.customLanguages);