SystemSh0cker/monaco-editor
1
0
Fork 0
mirror of https://github.com/microsoft/monaco-editor.git synced 2025-12-22 20:52:56 +01:00
Code Issues Projects Releases Packages Activity

Fixes https://github.com/microsoft/monaco-editor/issues/4799 (#4895)

Browse source 
* Fixes https://github.com/microsoft/monaco-editor/issues/4799

* updates ubuntu version

* Update ci.yml

This change pins the GitHub Actions runner to Ubuntu 22.04 instead of the default ubuntu-latest (currently 24.04) because Playwright's install-deps script is not yet compatible with Ubuntu 24.04. Several packages it tries to install—such as libasound2, libffi7, and libx264-163—have been removed, renamed, or replaced in 24.04, causing the dependency installation to fail and the CI job to exit with an error. Ubuntu 22.04 remains fully supported by Playwright and ensures a stable, consistent environment for browser testing and dependency management until 24.04 compatibility is added upstream.

---------

Co-authored-by: Megan Rogge <megan.rogge@microsoft.com>
This commit is contained in:
Henning Dieterichs 2025-05-08 18:19:05 +02:00 • committed by GitHub
parent 495d075be0
commit dd6bdfe8da
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/ci.yml vendored
View file

@ -5,7 +5,7 @@ on: [push, pull_request]
jobs: jobs:
build: build:
name: CI name: CI
runs-on: ubuntu-20.04 runs-on: ubuntu-22.04
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4

8
website/src/website/pages/playground/PlaygroundPageContent.tsx
View file

@ -19,7 +19,6 @@ import { Preview } from "./Preview";
import { SettingsDialog } from "./SettingsDialog"; import { SettingsDialog } from "./SettingsDialog";
import { getNpmVersionsSync } from "./getNpmVersionsSync"; import { getNpmVersionsSync } from "./getNpmVersionsSync";
import { PlaygroundExample, getPlaygroundExamples } from "./playgroundExamples"; import { PlaygroundExample, getPlaygroundExamples } from "./playgroundExamples";
import { getDefaultSettings, toLoaderConfig } from "./SettingsModel";
@hotComponent(module) @hotComponent(module)
@observer @observer
@ -85,6 +84,7 @@ export class PlaygroundPageContent extends React.Component<
} }
> >
<Editor <Editor
label="JavaScript Input"
language={"javascript"} language={"javascript"}
value={ref(model, "js")} value={ref(model, "js")}
/> />
@ -94,6 +94,7 @@ export class PlaygroundPageContent extends React.Component<
<div> <div>
<LabeledEditor label="HTML"> <LabeledEditor label="HTML">
<Editor <Editor
label="HTML Input"
height={{ height={{
kind: "dynamic", kind: "dynamic",
maxHeight: 200, maxHeight: 200,
@ -107,6 +108,7 @@ export class PlaygroundPageContent extends React.Component<
<div> <div>
<LabeledEditor label="CSS"> <LabeledEditor label="CSS">
<Editor <Editor
label="CSS Input"
height={{ height={{
kind: "dynamic", kind: "dynamic",
maxHeight: 200, maxHeight: 200,
@ -480,6 +482,7 @@ class Editor extends React.Component<{
language: string; language: string;
value: IReference<string>; value: IReference<string>;
height?: MonacoEditorHeight; height?: MonacoEditorHeight;
label: string;
}> { }> {
private editor: monaco.editor.IStandaloneCodeEditor | undefined = undefined; private editor: monaco.editor.IStandaloneCodeEditor | undefined = undefined;
private disposables: monaco.IDisposable[] = []; private disposables: monaco.IDisposable[] = [];
@ -504,6 +507,9 @@ class Editor extends React.Component<{
initializeEditor(editor: monaco.editor.IStandaloneCodeEditor) { initializeEditor(editor: monaco.editor.IStandaloneCodeEditor) {
this.editor = editor; this.editor = editor;
editor.updateOptions({
ariaLabel: this.props.label,
});
this.disposables.push(this.editor); this.disposables.push(this.editor);
this.disposables.push( this.disposables.push(
this.editor.onDidChangeModelContent((e) => { this.editor.onDidChangeModelContent((e) => {